Ignore RegExp property overrides when cloning - #58225
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The structured-clone polyfill reads user-visible RegExp
source/flags, allowing own overrides to replace internal state. Capture and call the built-in source and individual flag getters, feature-detectingd/v, and construct canonicaldgimsuvyflags directly from internal slots.Fixes #58224.
Changelog:
[GENERAL] [FIXED] - Clone RegExp internal source and flags without using property overrides.
Test Plan:
/foo/gwith shadowed properties as/bar/.source, aggregateflags, and every individual flag property with conflicting values; the clone remains/foo/g.structuredClone.yarn flow-check: 0 errors.git diff --checkpassed.Root review caught that the first draft's captured aggregate
flagsgetter still read per-flag overrides; the final head uses the individual intrinsics. No UI change; screenshots are not applicable.